Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131
Problem
On narrow screens (for example phones), the long GitHub URL in the red "This website is still under development" notice can't wrap, so it spills out of the box on the right side.
Fix
Added a
notice-bodyclass to themessage-bodydiv of both notice boxes insrc/routes/+layout.svelte(the dev notice and the translation notice). The class setsoverflow-wrap: anywhere, so long words and URLs wrap inside the box. The rule is scoped to this component, so nothing else on the site is affected.Testing
Checked in browser devtools at about 380px width: the URL now wraps inside the box instead of overflowing. Desktop layout is unchanged.
Screenshots
Before:
After:
See preview on Cloudflare Pages: https://preview-136.developer-wiki.pages.dev